From 59efca764c03450717f8544d96902624bcd6cad0 Mon Sep 17 00:00:00 2001
From: sshcrack <34072808+sshcrack@users.noreply.github.com>
Date: Tue, 22 Oct 2024 21:20:22 +0200
Subject: [PATCH] removed creation of shortcuts for flatpak / appimage users

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
---
 launcher/ui/MainWindow.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/launcher/ui/MainWindow.cpp b/launcher/ui/MainWindow.cpp
index 0961a5c4e..8979667f0 100644
--- a/launcher/ui/MainWindow.cpp
+++ b/launcher/ui/MainWindow.cpp
@@ -1633,6 +1633,7 @@ void MainWindow::on_actionCreateInstanceShortcut_triggered()
 #endif
         args.append({ "--launch", m_selectedInstance->id() });
 
+        bool userDefinedShortcutPath = !shortcutFilePath.isEmpty();
         if (shortcutFilePath.isEmpty())
             shortcutFilePath = FS::PathCombine(shortcutDirPath, FS::RemoveInvalidFilenameChars(m_selectedInstance->name()));
         if (!FS::createShortcut(shortcutFilePath, appPath, args, m_selectedInstance->name(), iconPath)) {
@@ -1640,7 +1641,11 @@ void MainWindow::on_actionCreateInstanceShortcut_triggered()
             iconFile.remove();
 #endif
             QMessageBox::critical(this, tr("Create instance shortcut"), tr("Failed to create instance shortcut!"));
+            return;
         }
+
+        if(userDefinedShortcutPath)
+            break;
     }
 #if not defined(Q_OS_MACOS)
     QMessageBox::information(this, tr("Create instance shortcut"), tr("Created a shortcut to this instance!"));