From 12a49154207761bb5cfcf023c6f318d71dcb24b5 Mon Sep 17 00:00:00 2001 From: Alexandru Ionut Tripon Date: Fri, 21 Feb 2025 11:32:30 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: TheKodeToad Signed-off-by: Alexandru Ionut Tripon --- launcher/minecraft/skins/SkinModel.cpp | 6 +++--- launcher/ui/dialogs/skins/draw/SkinOpenGLWindow.cpp | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/launcher/minecraft/skins/SkinModel.cpp b/launcher/minecraft/skins/SkinModel.cpp index 1358b47ea..b609bc6c7 100644 --- a/launcher/minecraft/skins/SkinModel.cpp +++ b/launcher/minecraft/skins/SkinModel.cpp @@ -23,7 +23,7 @@ #include "FileSystem.h" #include "Json.h" -QImage improveSkin(const QImage& skin) +static QImage improveSkin(const QImage& skin) { if (skin.size() == QSize(64, 32)) { // old format QImage newSkin = QImage(QSize(64, 64), skin.format()); @@ -40,12 +40,12 @@ QImage improveSkin(const QImage& skin) } return skin; } -QImage getSkin(const QString path) +static QImage getSkin(const QString path) { return improveSkin(QImage(path)); } -QImage generatePreviews(QImage texture, bool slim) +static QImage generatePreviews(QImage texture, bool slim) { QImage preview(36, 36, QImage::Format_ARGB32); preview.fill(Qt::transparent); diff --git a/launcher/ui/dialogs/skins/draw/SkinOpenGLWindow.cpp b/launcher/ui/dialogs/skins/draw/SkinOpenGLWindow.cpp index f611d6008..97fe44175 100644 --- a/launcher/ui/dialogs/skins/draw/SkinOpenGLWindow.cpp +++ b/launcher/ui/dialogs/skins/draw/SkinOpenGLWindow.cpp @@ -22,6 +22,7 @@ #include #include #include +#include #include "minecraft/skins/SkinModel.h" #include "rainbow.h"