Mirrors/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2025-04-29 22:24:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make deleting a verb

Browse Source 
Signed-off-by: Yihe Li <winmikedows@hotmail.com>
This commit is contained in:
Yihe Li 2025-03-27 15:59:10 +08:00
parent 45368fbf2f
commit 11a0dbf810
No known key found for this signature in database
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
launcher/InstanceDirUpdate.cpp
View File

@ -93,7 +93,7 @@ QString askToUpdateInstanceDirName(InstancePtr instance, QWidget* parent)
} }
// Check for linked instances // Check for linked instances
if (!checkLinkedInstances(instance->id(), parent)) if (!checkLinkedInstances(instance->id(), parent, QObject::tr("Renaming")))
return QString(); return QString();
// Now we can confirm that a renaming is happening // Now we can confirm that a renaming is happening
@ -109,17 +109,18 @@ QString askToUpdateInstanceDirName(InstancePtr instance, QWidget* parent)
return newRoot; return newRoot;
} }
bool checkLinkedInstances(const QString& id, QWidget* parent) bool checkLinkedInstances(const QString& id, QWidget* parent, const QString& verb)
{ {
auto linkedInstances = APPLICATION->instances()->getLinkedInstancesById(id); auto linkedInstances = APPLICATION->instances()->getLinkedInstancesById(id);
if (!linkedInstances.empty()) { if (!linkedInstances.empty()) {
auto response = CustomMessageBox::selectable(parent, QObject::tr("There are linked instances"), auto response = CustomMessageBox::selectable(parent, QObject::tr("There are linked instances"),
QObject::tr("The following instance(s) might reference files in this instance:\n\n" QObject::tr("The following instance(s) might reference files in this instance:\n\n"
"%1\n\n" "%1\n\n"
"Deleting it could break the other instance(s), \n\n" "%2 it could break the other instance(s), \n\n"
"Do you wish to proceed?", "Do you wish to proceed?",
nullptr, linkedInstances.count()) nullptr, linkedInstances.count())
.arg(linkedInstances.join("\n")), .arg(linkedInstances.join("\n"))
.arg(verb),
QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No) QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
->exec(); ->exec();
if (response != QMessageBox::Yes) if (response != QMessageBox::Yes)

2
launcher/InstanceDirUpdate.h
View File

@ -43,4 +43,4 @@
QString askToUpdateInstanceDirName(InstancePtr instance, QWidget* parent); QString askToUpdateInstanceDirName(InstancePtr instance, QWidget* parent);
/// Check if there are linked instances, and display a warning; return true if the operation should proceed /// Check if there are linked instances, and display a warning; return true if the operation should proceed
bool checkLinkedInstances(const QString& id, QWidget* parent); bool checkLinkedInstances(const QString& id, QWidget* parent, const QString& verb);

2
launcher/ui/MainWindow.cpp
View File

@ -1396,7 +1396,7 @@ void MainWindow::on_actionDeleteInstance_triggered()
if (response != QMessageBox::Yes) if (response != QMessageBox::Yes)
return; return;
if (!checkLinkedInstances(id, this)) if (!checkLinkedInstances(id, this, tr("Deleting")))
return; return;
if (APPLICATION->instances()->trashInstance(id)) { if (APPLICATION->instances()->trashInstance(id)) {