mirror of
https://github.com/PrismLauncher/PrismLauncher.git
synced 2025-06-13 05:37:42 +02:00
Apply suggestions from code review
Co-authored-by: seth <getchoo@tuta.io> Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
This commit is contained in:

committed by
GitHub

parent
4358e28d7e
commit
0a71b19509
@ -265,17 +265,17 @@ void ProfileSetupDialog::setupProfileFinished()
|
|||||||
auto parsedError = MojangError::fromJSON(*m_profile_response);
|
auto parsedError = MojangError::fromJSON(*m_profile_response);
|
||||||
ui->errorLabel->setVisible(true);
|
ui->errorLabel->setVisible(true);
|
||||||
|
|
||||||
QString errorMessage = tr("Network error(%1): %2 ;HTTP Status: %3")
|
QString errorMessage = tr("Network error(%1): %2: HTTP Status: %3")
|
||||||
.arg(QString::number(m_profile_task->error()), m_profile_task->errorString(),
|
.arg(QString::number(m_profile_task->error()), m_profile_task->errorString(),
|
||||||
QString::number(m_profile_task->replyStatusCode()));
|
QString::number(m_profile_task->replyStatusCode()));
|
||||||
|
|
||||||
if (parsedError.fullyParsed) {
|
if (parsedError.fullyParsed) {
|
||||||
errorMessage += "Path: " + parsedError.path + "\n";
|
errorMessage += "Path: " + parsedError.path + "\n";
|
||||||
errorMessage += "Error: " + parsedError.error + "\n";
|
errorMessage += "Error: " + parsedError.error + "\n";
|
||||||
errorMessage += "Error message: " + parsedError.errorMessage + "\n";
|
errorMessage += "Message: " + parsedError.errorMessage + "\n";
|
||||||
} else {
|
} else {
|
||||||
errorMessage += "Failed to parse Mojang error: " + parsedError.parseError.errorString() + "\n";
|
errorMessage += "Failed to parse error from Mojang API: " + parsedError.parseError.errorString() + "\n";
|
||||||
errorMessage += "Raw contents:\n" + parsedError.rawError + "\n";
|
errorMessage += "Log:\n" + parsedError.rawError + "\n";
|
||||||
}
|
}
|
||||||
|
|
||||||
ui->errorLabel->setText(tr("The server returned the following error:") + "\n\n" + errorMessage);
|
ui->errorLabel->setText(tr("The server returned the following error:") + "\n\n" + errorMessage);
|
||||||
|
Reference in New Issue
Block a user