Skip stub APK install on emulator

Reduce test flakiness
This commit is contained in:
topjohnwu 2025-03-26 12:40:57 -07:00 committed by John Wu
parent e66fe8533e
commit 2aba7247a9

View File

@ -1,11 +1,11 @@
use crate::consts::{APP_PACKAGE_NAME, MAGISK_VER_CODE}; use crate::consts::{APP_PACKAGE_NAME, MAGISK_VER_CODE};
use crate::daemon::{to_app_id, MagiskD, AID_APP_END, AID_APP_START, AID_USER_OFFSET}; use crate::daemon::{AID_APP_END, AID_APP_START, AID_USER_OFFSET, MagiskD, to_app_id};
use crate::ffi::{get_magisk_tmp, install_apk, uninstall_pkg, DbEntryKey}; use crate::ffi::{DbEntryKey, get_magisk_tmp, install_apk, uninstall_pkg};
use base::libc::{O_CLOEXEC, O_CREAT, O_RDONLY, O_TRUNC, O_WRONLY};
use base::WalkResult::{Abort, Continue, Skip}; use base::WalkResult::{Abort, Continue, Skip};
use base::libc::{O_CLOEXEC, O_CREAT, O_RDONLY, O_TRUNC, O_WRONLY};
use base::{ use base::{
cstr, cstr_buf, error, fd_get_attr, open_fd, warn, BufReadExt, Directory, FsPath, FsPathBuf, BufReadExt, Directory, FsPath, FsPathBuf, LoggedResult, ReadExt, ResultExt, Utf8CStrBuf, cstr,
LoggedResult, ReadExt, ResultExt, Utf8CStrBuf, cstr_buf, error, fd_get_attr, open_fd, warn,
}; };
use bit_set::BitSet; use bit_set::BitSet;
use cxx::CxxString; use cxx::CxxString;
@ -357,7 +357,7 @@ impl ManagerInfo {
{ {
// no APK // no APK
if file.path == Path::new("/data/system/packages.xml") { if file.path == Path::new("/data/system/packages.xml") {
if install { if install && !daemon.is_emulator {
self.install_stub(); self.install_stub();
} }
return (-1, ""); return (-1, "");
@ -402,7 +402,7 @@ impl ManagerInfo {
) )
} else { } else {
(-1, "") (-1, "")
} };
} }
Status::NotInstalled => { Status::NotInstalled => {
daemon.rm_db_string(DbEntryKey::SuManager).ok(); daemon.rm_db_string(DbEntryKey::SuManager).ok();
@ -434,7 +434,7 @@ impl ManagerInfo {
self.tracked_files self.tracked_files
.insert(user, TrackedFile::new("/data/system/packages.xml")); .insert(user, TrackedFile::new("/data/system/packages.xml"));
if install { if install && !daemon.is_emulator {
self.install_stub(); self.install_stub();
} }
(-1, "") (-1, "")